CPLAT-11722 Add uiForwardRef#612
Conversation
…ct into CPLAT-11722-add-uiForwardRef
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| (props) { | ||
| return Dom.div()(); | ||
| }, | ||
| $BarPropsMixinConfig, // ignore: undefined_identifier |
There was a problem hiding this comment.
This seems like it should have been $BarConfig from the get go - my parser change use the name to detect that it's a generated config and therefore enforces the naming pattern ${FactoryName}Config. Let me know if this doesn't work, though!
| (props) { | ||
| return Dom.div()(); | ||
| }, | ||
| \$FooConfig, // ignore: undefined_identifier |
There was a problem hiding this comment.
This seems like it should have been $BarConfig from the get go - my parser change use the name to detect that it's a generated config and therefore enforces the naming pattern ${FactoryName}Config. Let me know if this doesn't work, though!
b8f4969 to
7d288eb
Compare
| } | ||
|
|
||
| extension<E> on Iterable<E> { | ||
| void forEachIndexed(void Function(E, int) callback) { |
There was a problem hiding this comment.
The new analyzer version made improvements to the analysis of extensions and caught this was unused
|
talked to Joe about some puzzling things I found while QAing and he's going to take a look - |
greglittlefield-wf
left a comment
There was a problem hiding this comment.
Just formatting and one minor thing
|
QA +1 tested functionality in
|
|
QA +1 still stands - latest commit is a wording change only |
aaronlademann-wf
left a comment
There was a problem hiding this comment.
+1
@Workiva/release-management-pp
Motivation
When planning function components, we missed a couple cases:
Example: https://reactjs.org/docs/forwarding-refs.html#forwarding-refs-to-dom-components
Changes
API Changes:
uiForwardRefuiForwardRefuiForwardReftestsBuilder Changes:
FunctionComponentConfigtoUiFactoryConfigisFunctionComponentFactorytoshouldGenerateConfigIdentifierthat can be used to check if the name is a factory typeUiFactoryConfigRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: